Repository navigation
mkconcore: find labels in any <data> child and warn when nodes/edges are skipped - #705
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
…elements are skipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #704
mkconcore only looked at the first child of each node/edge. yEd can write an empty before the one holding the label (e.g. testsou/pretty.graphml), so those nodes and edges were skipped silently, while
concore validate/inspectread the same file correctly.Added tests/test_mkconcore_skipped_elements.py (5 tests); the yEd-structure and warning tests fail without the change. The three affected sample files now build their nodes, and the other sample graphs produce no new warnings.